unixPB: improves Ant-Contrib role compatibility
#3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahdipub linter failures |
|
Given the comment above the line, This needs to be tested on Solaris before it can be approved. |
It helps improve `Ant-Contrib` role by replacing wget with get_url module. Also when extracting, on macos the `unarchive` module might fails as it asks for gtar but default macos tar is `bsdtar`. The workaround is to run it as command on macos machines. Signed-off-by: [email protected]
mahdipub
force-pushed
the
ant_contrib_role_improvement
branch
from
45d9d88
to
dd6d373
Compare
Thanks, that's resolved. |
Don't see Solaris as part of that run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps improve
Ant-Contribrole by replacing wget with get_url module. Also when extracing, on macos theunarchivemodule might fails as it asks for gtar but default macos tar isbsdtar. The workaround is to run it as command on macos machines.Signed-off-by: [email protected]
Checklist